fix: make save_init_options() write atomically - #3924
Open
Quratulain-bilal wants to merge 1 commit into
Open
Conversation
…n crash write_text() directly to the target file risks leaving a partially written (corrupted) file if the process is killed mid-write. Use mkstemp + os.replace for atomic write.
Contributor
There was a problem hiding this comment.
Pull request overview
Makes init-options persistence atomic to prevent partial writes.
Changes:
- Writes JSON to a same-directory temporary file.
- Atomically replaces the destination and cleans up on failure.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/_init_options.py |
Implements atomic init-options writes. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+33
to
+37
| try: | ||
| with os.fdopen(fd, "w", encoding="utf-8") as f: | ||
| json.dump(options, f, indent=2, sort_keys=True, ensure_ascii=False) | ||
| f.write("\n") | ||
| os.replace(tmp, dest) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
write_text()directly to the target file risks leaving a partially written (corrupted) file if the process is killed mid-write.Fix
Use
mkstemp+os.replacefor atomic write.